Skip to content

Conversation

pcarranzav
Copy link
Member

@pcarranzav pcarranzav commented Oct 31, 2022

With the way it worked up to now, _data.length would always be nonzero, so we were calling the callhooks always, even when transferring to an EOA! This removes those unnecessary emptyBytes (which were there just to keep the gateway similar to Arbitrum's gateway implementation), and now _data on the L2 side will be the callhook data sent from L1, and therefore zero length if there is no callhook to call.

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 91.60% // Head: 91.58% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (caf5ab5) compared to base (ce0d0a3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                Coverage Diff                @@
##           pcv/c4-699-qa     #745      +/-   ##
=================================================
- Coverage          91.60%   91.58%   -0.02%     
=================================================
  Files                 42       42              
  Lines               2000     1997       -3     
  Branches             361      361              
=================================================
- Hits                1832     1829       -3     
  Misses               168      168              
Flag Coverage Δ
unittests 91.58% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contracts/gateway/L1GraphTokenGateway.sol 100.00% <ø> (ø)
contracts/l2/gateway/L2GraphTokenGateway.sol 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Base automatically changed from pcv/c4-699-qa to pcv/l2-bridge November 23, 2022 14:37
@pcarranzav pcarranzav merged commit caf5ab5 into pcv/l2-bridge Nov 23, 2022
@pcarranzav pcarranzav deleted the pcv/fix-bridge-callhook-data branch November 23, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants