Use Authorizable for GraphTallyCollector #1110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| anotherPayer | ||
| ); | ||
| vm.expectRevert(expectedError); | ||
| vm.expectRevert(IGraphTallyCollector.GraphTallyCollectorInvalidRAVSigner.selector); |
There was a problem hiding this comment.
This is slightly different to the original implementation
| users.gateway, | ||
| signer | ||
| ); | ||
| vm.expectRevert(expectedError); | ||
| graphTallyCollector.thawSigner(signer); | ||
| } | ||
|
|
||
| function testGraphTally_ThawSigner_RevertWhen_AlreadyThawing() public useGateway useSigner { | ||
| function testGraphTally_ThawSigner_AlreadyThawing() public useGateway useSigner { |
There was a problem hiding this comment.
This is different to the original implementation. Where originally it would revert, now it resets the thaw timer.
This was referenced Feb 13, 2025
matiasedgeandnode
changed the title
Use Authorizable for GraphTallyCollector
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
matiasedgeandnode
force-pushed
the
ma/horizon-authorizable
branch
from
4f39008 to
1b7d13a
Compare
matiasedgeandnode
force-pushed
the
ma/horizon-authorizable
branch
from
1b7d13a to
3c57398
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.