Skip to content

Commit

Permalink
Properly find e2e tests to run in the default runner (kubernetes#375)
Browse files Browse the repository at this point in the history
Listing scripts to run using shell expansion fails if there are no scripts in `/test` (shell expansion won't occur, and the raw string will be interpreted as a script name). Use `find` instead, which can deal with this edge case.
  • Loading branch information
adrcunha authored and knative-prow-robot committed Jan 10, 2019
1 parent d48d493 commit 722c046
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/presubmit-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ function default_integration_test_runner() {
local options=""
local failed=0
(( EMIT_METRICS )) && options="--emit-metrics"
for e2e_test in ./test/e2e-*tests.sh; do
for e2e_test in $(find test/ -name e2e-*tests.sh); do
echo "Running integration test ${e2e_test}"
if ! ${e2e_test} ${options}; then
failed=1
Expand Down

0 comments on commit 722c046

Please sign in to comment.