Skip to content

allow looking up language by filename#22

Closed
tmm1 wants to merge 2 commits intograntjenks:mainfrom
tmm1:lang-detect
Closed

allow looking up language by filename#22
tmm1 wants to merge 2 commits intograntjenks:mainfrom
tmm1:lang-detect

Conversation

@tmm1
Copy link
Copy Markdown

@tmm1 tmm1 commented Jul 27, 2023

@grantjenks
Copy link
Copy Markdown
Owner

Should this go in py-tree-sitter instead? Seems like a simple script to generate a language file which would be generally useful. I understand it’s related here to the binaries included in the package but I’d rather not maintain it myself.

@tmm1
Copy link
Copy Markdown
Author

tmm1 commented Jul 28, 2023

Yea that's a fair point. Perhaps py-tree-sitter should generate a languages_index.py alongside the languages.so, and then all you have to do is copy it over.

I'll work on an upstream PR, but if it gets stuck in limbo perhaps we can ship this and refactor later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Language detection

2 participants