Updated rca calculation with rsmin and rsmax limits.#6
Merged
Conversation
Owner
|
Thanks @drnimbusrain. I'll go ahead and merge this in to the PR. |
grantfirl
pushed a commit
that referenced
this pull request
Apr 16, 2025
… fix OpenMP bugs) (#6) Update CMakeLists.txt to: - Bring in updates from NCAR ccpp-physics main as needed and update CMakeLists.txt to modern cmake version 3 - Support NEPTUNE cmake build while retaining compatibility with UFS/SCM - Fix existing bugs for assigning compilation flags: OpenMP on/off wasn't handled correctly, some schemes had host model flags applied twice. Fixing the OpenMP flags triggered an error in the OpenMP-on build in NEPTUNE that this PR fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@grantfirl I needed to add some limits to this rca calculation (based on rsmin and rsmax from Noah-MP tables), as the coupled AQM is very sensitive to very high or low stomatal resistances coming out of Noah-MP. Ultimately, more investigation and testing will be needed in coupling and maybe tuning this rca calculation for the coupled AQM. For now it is more reasonable for AQM to move this forward at this point. Thanks!