Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form-validation-fixes #408

Conversation

fareedk2
Copy link
Contributor

Resolves #issueNumber
Type: feature|bugfix|

Issue

Description of the issue this PR is solving, why it's happening, and how to reproduce it.

Solution

Summarize your solution to the problem. Please include short description.

Breaking changes

If you have a breaking changes, list them here, otherwise list none.

Testing

  1. List the steps needed for testing your PR.
  2. Assume that everyone already know how to run the GrandNode, and do the basic configuration.
  3. Be detailed enough that someone can work through it easily.

@fareedk2 fareedk2 changed the title Infokit-form-error-messages-by-min-length-fixes form-validation-fixes May 23, 2023
@SunilParisi123
Copy link
Contributor

When there is a min length validation on a field and when user not overwrite any validation text, currently it's showing the message as "'This ' + fieldName + ' should have at least characters.'". This is not giving the more information on how many characters required as minimum. There can be multiple fields with different Min length requirements. So it's better to have the message explicitly include the Minimum length characters in the error message. This PR is addressing this issue.

@SunilParisi123
Copy link
Contributor

@KrzysztofPajak Can this be included?

@KrzysztofPajak
Copy link
Member

@SunilParisi123 Thanks, yes your PR will be merge

@KrzysztofPajak KrzysztofPajak merged commit 4863ff7 into grandnode:main Jun 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants