Skip to content

feat: Add SSZ response support for validator_balances endpoints - #801

Merged
povi merged 3 commits into
grandinetech:developfrom
NikhilSharmaWe:feat/validator-balances-ssz
Jul 30, 2026
Merged

feat: Add SSZ response support for validator_balances endpoints#801
povi merged 3 commits into
grandinetech:developfrom
NikhilSharmaWe:feat/validator-balances-ssz

Conversation

@NikhilSharmaWe

Copy link
Copy Markdown
Contributor

Closes #793

Adds SSZ (application/octet-stream) response support to GET and POST /eth/v1/beacon/states/{state_id}/validator_balances, per beacon-APIs #622.

Clients opt in via Accept: application/octet-stream. JSON behavior is unchanged.

@NikhilSharmaWe

NikhilSharmaWe commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

Companion snapshot-tests PR: grandinetech/grandine-snapshot-tests#7

@hangleang I kept this PR focused on the API change, so I haven’t bumped the submodule yet. Once grandinetech/grandine-snapshot-tests#7 merges to main, I can push that update here right away.

As I’m new to the project, does this sequence look right, or would you prefer a different order for paired grandine / grandine-snapshot-tests PRs?

@hangleang

Copy link
Copy Markdown
Member

As I’m new to the project, does this sequence look right, or would you prefer a different order for paired grandine / grandine-snapshot-tests PRs?

Just commit with the snapshot tests, make sure the tests is published to remote. I will allow CI to run after that

Signed-off-by: Nikhil Sharma <nikhilsharma230303@gmail.com>
@NikhilSharmaWe

Copy link
Copy Markdown
Contributor Author

As I’m new to the project, does this sequence look right, or would you prefer a different order for paired grandine / grandine-snapshot-tests PRs?

Just commit with the snapshot tests, make sure the tests is published to remote. I will allow CI to run after that

Pushed the submodule bump

Signed-off-by: Nikhil Sharma <nikhilsharma230303@gmail.com>
@NikhilSharmaWe

Copy link
Copy Markdown
Contributor Author

@hangleang applied a fix for the Clippy type_complexity failure - added the missing #[expect(clippy::type_complexity)] on the GET handler and shared helper. Should be good for CI now.

@hangleang
hangleang requested a review from povi July 14, 2026 07:37
@hangleang

Copy link
Copy Markdown
Member

@povi could you give a yes or no for this PR? it is looks good to me

@povi povi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@povi
povi merged commit 70a5c7e into grandinetech:develop Jul 30, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Glamsterdam] Add SSZ response support for validator_balances endpoints

3 participants