Add target_gas_limit to PayloadAttributes - #693
Merged
Tumas merged 1 commit intoMay 18, 2026
Conversation
Update bindings
hangleang
commented
May 15, 2026
| }) | ||
| } | ||
|
|
||
| async fn gas_limit(&self) -> Result<Gas> { |
Member
Author
Collaborator
There was a problem hiding this comment.
There is this endpoint, which we already implement (also whole API): https://ethereum.github.io/keymanager-APIs/?urls.primaryName=dev#/Gas%20Limit/setGasLimit
Member
Author
There was a problem hiding this comment.
yes, I see. but how can we load it in block building like fee_recipient?
Collaborator
There was a problem hiding this comment.
We already pass preferred gas limit to external builders: https://github.com/grandinetech/grandine/blob/develop/validator/src/validator.rs#L2295
You can do something like that in block producer.
Member
Author
There was a problem hiding this comment.
Okay, that's what I did. So it's fine
Tumas
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement ethereum/consensus-specs#5235