Add missing SSE events - #691
Merged
hangleang merged 1 commit intoJul 17, 2026
Merged
Conversation
povi
approved these changes
May 14, 2026
hangleang
force-pushed
the
feature/proposer-preferences-event
branch
from
July 12, 2026 07:22
409f341 to
ed34669
Compare
hangleang
changed the base branch from
glamsterdam-devnet-3
to
glamsterdam-devnet-7
July 12, 2026 07:22
hangleang
marked this pull request as ready for review
July 12, 2026 07:23
hangleang
force-pushed
the
feature/proposer-preferences-event
branch
2 times, most recently
from
July 16, 2026 09:45
74f0b10 to
30595fe
Compare
povi
reviewed
Jul 16, 2026
|
|
||
| self.event_channels | ||
| .send_head_v2_event(head, self.store.head_payload_status(), |head| { | ||
| self.calculate_dependent_roots(head) |
Collaborator
There was a problem hiding this comment.
You could just calculate dependent roots bundle beforehand and pass it as an argument to send_head_v2_event. Then there would be no need to pass anonymous functions as a parameter, and it would do one calculate_dependent_roots call instead of two.
Other than that, LGTM
Member
Author
There was a problem hiding this comment.
I will merge this PR after the build pass
hangleang
force-pushed
the
feature/proposer-preferences-event
branch
from
July 17, 2026 07:24
30595fe to
08c63ce
Compare
- Add proposer preferences event - Rename SSE `payload_attestation` to `payload_attestation_message` event topic - Add head_v2 SSE
hangleang
force-pushed
the
feature/proposer-preferences-event
branch
from
July 17, 2026 08:14
08c63ce to
21f43a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repurpose the PR to add missing SSE events as of report in https://investigations.ethpandaops.io/2026-07/glamsterdam-event-client-matrix/
Closes #800