Skip to content

rebase PeerDAS onto electra #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 63 commits into from
Closed

rebase PeerDAS onto electra #55

wants to merge 63 commits into from

Conversation

@hangleang
Copy link
Collaborator

@hangleang hangleang commented Nov 10, 2024

this pull request will rebase the functionality of PeerDAS onto electra fork, this final update should express the current status of the implementation. this will be ready for review once these following PRs in other parts of the codebase merged into the upstream branch, then I will link the submodules to those commits:

@CLAassistant
Copy link

CLAassistant commented Nov 10, 2024 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ hangleang
✅ Tumas
✅ povi
❌ weekday-grandine-io
You have signed the CLA already but the status is still pending? Let us recheck it.

@hangleang hangleang marked this pull request as draft November 10, 2024 06:44
@hangleang hangleang mentioned this pull request Nov 10, 2024
Closed
Mdominykas and others added 27 commits November 28, 2024 14:46
@hangleang
implemented get_custody_columns
a525482
@hangleang
wip
0ed322d
@hangleang
implemented compute_extended_matrix
f181cf1
@hangleang
wip
c508ffd
@hangleang
implemented recover_matrix
b243675
@hangleang
implemented get_data_column_sidecars
f629c60
@hangleang
moved c-kzg to dependencies
26bbfab
@hangleang
further validation
f6abe5c
@hangleang
moved data sidecar verification to fork_choice_store
e7410d4
@hangleang
data sidecar verifcation
202c01b
@hangleang
fixed bug
4b9833a
@hangleang
added tests. They fail, but in a same way as lighthouse
cabea4c
@hangleang
added part of networking
03cae9e
@Tumas @hangleang
make it compile
b0de8b1
@Tumas @hangleang
use consensus spec tests latest versions
c2260d4
@Tumas @hangleang
WIP: move eip7594 types to types crate, add ssz_static tests for cont…
9590355 
…ainers
@Tumas @hangleang
Adjust types, make tests pass for DataColumnSidecar container
790521f
@Tumas @hangleang
Add empty kzg_commitment_inclusion_proof and consensus tests for it
47a02c4
@Tumas @hangleang
Use SubnetId for DataColumnSidecar subnets
25be79d
@weekday-grandine-io @hangleang
Fix inclusion proof construction in EIP-7594
2d809d8 
WARNING: EIP-7594 contains a new preset variable with a name nearly identical to an older one.
Compare:
KZG_COMMITMENT_INCLUSION_PROOF_DEPTH  added in Deneb.
KZG_COMMITMENTS_INCLUSION_PROOF_DEPTH added in EIP-7594.

Also note that neither variable is independent.
KZG_COMMITMENT_INCLUSION_PROOF_DEPTH is derived from MAX_BLOB_COMMITMENTS_PER_BLOCK.
KZG_COMMITMENTS_INCLUSION_PROOF_DEPTH is effectively a constant.
@Tumas @hangleang
Rebase eth2_libp2p
5f14941
@Tumas @hangleang
Update grandine-snapshot-tests to include EIP7594_FORK_EPOCH in Config
035428b
@Tumas @hangleang
Move DATA_COLUMN_SIDECAR_SUBNET_COUNT const to types
8c24663
@povi @hangleang
Check if block has more than 50% of data columns to accept it as valid
d99ac37
@Tumas @hangleang
update eth2_libp2p
27da10f
@hangleang
Validate pending block against it's parent's data availability
f4308d3
@Tumas @hangleang
WIP: Add DataColumnsByRoot rpc
23d3092
povi and others added 18 commits November 28, 2024 14:51
@povi @hangleang
Various fixes
6d740c7
@Tumas @hangleang
Relax parent availablity check
e615d2a
@povi @hangleang
Data column cache pruning
0244a48
@Tumas @hangleang
fix get_data_column_sidecars & improve code formatting
98a4c13
@povi @hangleang
Delay data column sidecars and retry processing them when conditions …
4c9ed21 
…allow
@Tumas @hangleang
Validate DataColumnSidecar subnet if it is present
20aa412
@povi @hangleang
Update constants
6a660f7
@Tumas @hangleang
Stub data column sidecar syncing
e75fe4a
@Tumas @hangleang
Use is_forward_synced for stub instead of initial_forward_sync
55ebe96
@Tumas @hangleang
Use hardcoded DATA_COLUMN_SIDECAR_COUNT (32) for now
0efd404
@Tumas @hangleang
Don't request blobs when das enabled
740fcfa
@Tumas @hangleang
apply stubbed availablity check for parent
2cf6e1f
@Tumas @hangleang
subscribe to all subnets by default
121c71a
@Tumas @hangleang
WIP: DataColumnsByRange RPC
d3040ab
@povi @hangleang
Data column cache
3726f36
@povi @hangleang
WIP: config
d9341ce
@hangleang
rebase feature/das onto develop branch
7cc9815
@hangleang
fix: rebase conflicts, reconstruction runtime error
4a957b2 
fix(wip): resolved conflicts after rebase

fix(wip): resolved code conflicted

fix: failed kzg_commitment_inclusion_proof tests and remove usued imports

fix: subscribe data column subnets if eip7594 scheduled

fix: kzg_inclusion_proofs in deneb and electra

fix: validate block with DA checking

update snapshot-tests, eth2_libp2p

fix: missing check in spec test

chore: sort custody subnets

fix: reconstruction runtime error

update
@will-corcoran
Copy link

will-corcoran commented Apr 7, 2025

Hi @hangleang is this the best place to track progress on PeerDAS?

@will-corcoran will-corcoran mentioned this pull request Apr 7, 2025
Closed
@hangleang
Copy link
Collaborator Author

hangleang commented Apr 8, 2025

Hi @hangleang is this the best place to track progress on PeerDAS?

Currently, only on my fork repo: https://github.com/hangleang/grandine. There are a main branch called peerdas-fulu and a number of feature branches.

We will have the main implementation in the origin repo (here) in weeks hopefully, once team are done on pectra and available to review the implementation.

@will-corcoran will-corcoran mentioned this pull request Apr 13, 2025
Closed
This was referenced Apr 21, 2025
Closed
Closed
@will-corcoran will-corcoran mentioned this pull request Apr 30, 2025
Closed
@will-corcoran will-corcoran mentioned this pull request May 11, 2025
Closed
@hangleang hangleang closed this May 14, 2025
@will-corcoran will-corcoran mentioned this pull request May 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hangleang @CLAassistant @will-corcoran @Tumas @weekday-grandine-io @povi