Skip to content

Add kzg_commitments field in DataColumnSidecarEvent stream #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
+8 −3
Merged

Add kzg_commitments field in DataColumnSidecarEvent stream #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions http_api_utils/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ prometheus_metrics = { workspace = true }
serde = { workspace = true }
serde_utils = { workspace = true }
serde_with = { workspace = true }
ssz = { workspace = true }
tap = { workspace = true }
thiserror = { workspace = true }
tower = { workspace = true }
Expand Down
9 changes: 6 additions & 3 deletions http_api_utils/src/events.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ use helper_functions::misc;
use log::warn;
use serde::Serialize;
use serde_with::DeserializeFromStr;
use ssz::ContiguousList;
use strum::{AsRefStr, EnumString};
use tap::Pipe as _;
use tokio::sync::broadcast::{self, Receiver, Sender};
Expand Down Expand Up @@ -489,20 +490,22 @@ impl BlobSidecarEvent {
}

#[derive(Debug, Serialize)]
struct DataColumnSidecarEvent {
struct DataColumnSidecarEvent<P: Preset> {
block_root: H256,
#[serde(with = "serde_utils::string_or_native")]
index: ColumnIndex,
#[serde(with = "serde_utils::string_or_native")]
slot: Slot,
kzg_commitments: ContiguousList<KzgCommitment, P::MaxBlobCommitmentsPerBlock>,
}

impl DataColumnSidecarEvent {
const fn new<P: Preset>(block_root: H256, data_column_sidecar: &DataColumnSidecar<P>) -> Self {
impl<P: Preset> DataColumnSidecarEvent<P> {
fn new(block_root: H256, data_column_sidecar: &DataColumnSidecar<P>) -> Self {
Self {
block_root,
index: data_column_sidecar.index,
slot: data_column_sidecar.slot(),
kzg_commitments: data_column_sidecar.kzg_commitments.clone(),
}
}
}
Expand Down