Commands plugin typo in flavor installation

[carafelix]

website/site/docs/plugins/commands.md

Line 107 in f644208

type MyContext = Context & CommandsFlavor;

 type MyContext = CommandsFlavor<Context>;

and

website/site/docs/plugins/commands.md

Lines 115 to 116 in f644208

	const loggedOutCommands = new CommandGroup();
	const loggedInCommands = new CommandGroup();

const loggedOutCommands = new CommandGroup<MyContext>();
const loggedInCommands = new CommandGroup<MyContext>();

[KnightNiwrem]

Technically, type MyContext = Context & CommandsFlavor is equivalent to type MyContext = Context & CommandsFlavor<Context>, since CommandsFlavor provides a default Context type where the parameter type is not given - i.e. interface CommandsFlavor<C extends Context = Context> extends Context {}.

Is there any particular reason why we want the Context & part when CommandsFlavor already extends Context?

Circular types feels a bit weird to me. I'm not sure what to think of it.

[carafelix]

Is there any particular reason why we want the Context & part when CommandsFlavor already extends Context?

as you pointed out: there isn't

[KnorpelSenf]

Should actually be:

 type MyContext = CommandsFlavor<Context>;