[LibOS] Rename async helper to async worker
#2318
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 30 files reviewed, 2 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL), "DONTMERGE" and "TODO" found in commit messages' one-liners (waiting on @boryspoplawski)
a discussion (no related file):
Grepping for async helper (case insensitive) also shows some mentions in db_threading.c, shim_thread.c, enclave_entry.S.
LibOS/shim/include/shim_utils.h, line 163 at r1 (raw file):
/* Asynchronous event support */ int init_async(void);
We have init_async() but init_ipc_worker. I suggest to rename this to init_async_worker for uniformity.
There was a problem hiding this comment.
Reviewable status: 0 of 30 files reviewed, 3 unresolved discussions, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: ITL), "DONTMERGE" and "TODO" found in commit messages' one-liners (waiting on @boryspoplawski)
a discussion (no related file):
@boryspoplawski The IPC Rework PR was merged, can you rebase this one?
boryspoplawski
force-pushed
the
borys/rename_async_helper
branch
from
8df5e8f to
7843399
Compare
boryspoplawski
force-pushed
the
borys/rename_async_helper
branch
from
7843399 to
5a80ab1
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 33 files reviewed, 3 unresolved discussions, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @dimakuv)
a discussion (no related file):
Previously, dimakuv (Dmitrii Kuvaiskii) wrote…
Grepping for
async helper(case insensitive) also shows some mentions indb_threading.c,shim_thread.c,enclave_entry.S.
Done.
a discussion (no related file):
Previously, dimakuv (Dmitrii Kuvaiskii) wrote…
@boryspoplawski The IPC Rework PR was merged, can you rebase this one?
Done.
LibOS/shim/include/shim_utils.h, line 163 at r1 (raw file):
Previously, dimakuv (Dmitrii Kuvaiskii) wrote…
We have
init_async()butinit_ipc_worker. I suggest to rename this toinit_async_workerfor uniformity.
Done.
Just to be consistent with IPC worker. Signed-off-by: Borys Popławski <[email protected]>
There was a problem hiding this comment.
Reviewed 27 of 27 files at r2.
Reviewable status: 27 of 33 files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewed 7 of 27 files at r2.
Reviewable status: 27 of 33 files reviewed, all discussions resolved
|
Jenkins, retest Jenkins-18.04 please ( |
There was a problem hiding this comment.
Reviewed 6 of 30 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Description of the changes
To be consistent with recent IPC worker rename.
This change is