[LibOS] Do not print errors on last TID release failure

If the IPC leader exits before all processes released their last IDs, those processe would exit with bunch of errors. Unfortunately this can happen legitimately, if the IPC leader exits right after doing `wait` syscall. Signed-off-by: Borys Popławski <[email protected]>
gramineproject · Jul 5, 2021 · 4f8d6fb · 4f8d6fb
1 parent 4e00671
commit 4f8d6fb
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/LibOS/shim/src/bookkeep/shim_pid.c b/LibOS/shim/src/bookkeep/shim_pid.c
@@ -168,8 +168,11 @@ void release_id(IDTYPE id) {
 
             int ret = ipc_release_id_range(range->start, range->end);
             if (ret < 0) {
-                log_error("IPC pid release failed");
-                die_or_inf_loop();
+                /* TODO: this is a fatal error, unfortunately it can happen if the IPC leader exits
+                 * without fully waiting for this process to end. For more information check
+                 * "LibOS/shim/src/sys/shim_exit.c". Change to `log_error` + `die` after fixing. */
+                log_warning("IPC pid release failed");
+                DkProcessExit(1);
             }
             free(range);
             return;