Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pal/Linux-SGX] Always open Protected Files in RW mode #78

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

boryspoplawski
Copy link
Contributor

@boryspoplawski boryspoplawski commented Sep 22, 2021

Description of the changes

A Protected File sometimes needs to be read or written, regardless of the actual open mode that was requested (e.g. to read or write some metadata).

How to test this PR?


This change is Reviewable

A Protected File sometimes needs to be read or written, regardless of
the actual open mode that was requested (e.g. to read or write some
metadata).

Signed-off-by: Borys Popławski <[email protected]>
Copy link
Member

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: ITL)

Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@boryspoplawski boryspoplawski merged commit ff5a2da into master Sep 22, 2021
@boryspoplawski boryspoplawski deleted the borys/pf_rw branch September 22, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants