Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAL] Change Dk prefix to Pal #685

Merged
merged 1 commit into from
Jun 28, 2022
Merged

[PAL] Change Dk prefix to Pal #685

merged 1 commit into from
Jun 28, 2022

Conversation

mkow
Copy link
Member

@mkow mkow commented Jun 27, 2022

Description of the changes

Next step of the renaming (see #667 and #687).


This change is Reviewable

Signed-off-by: Michał Kowalczyk <[email protected]>
Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 159 of 159 files at r1, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)

Copy link
Contributor

@boryspoplawski boryspoplawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 159 of 159 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


Documentation/devel/onboarding.rst line 629 at r1 (raw file):

     PAL API function (e.g., ``PalSomeNewFunction``). You will need to implement
     the entry-point function (``PalSomeNewFunction``) in the common PAL code,
     as well as each host-specific function (``_PalSomeNewFunction``) in each

Maybe it's time to address this now? _Capitalletter is reserved identifier in C.
Not blocking, since the PR is mergable

@dimakuv dimakuv merged commit ecca6b5 into master Jun 28, 2022
@dimakuv dimakuv deleted the mkow/dk-to-pal branch June 28, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants