Lowercase "LibOS", "Pal" and "Scripts" #672
Conversation
There was a problem hiding this comment.
Reviewed 630 of 630 files at r1, all commit messages.
Reviewable status: 600 of 660 files reviewed, all discussions resolved, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL), "fixup! " found in commit messages' one-liners (waiting on @boryspoplawski)
.gitmodules line 1 at r2 (raw file):
[submodule "LibOS/test/ltp/src"]
Not sure how to update this one (this is git internal file)
There was a problem hiding this comment.
Reviewable status: 599 of 660 files reviewed, all discussions resolved, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL), "fixup! " found in commit messages' one-liners (waiting on @boryspoplawski)
.gitmodules line 1 at r2 (raw file):
Previously, boryspoplawski (Borys Popławski) wrote…
Not sure how to update this one (this is git internal file)
Ok, just changes the name manually.
There was a problem hiding this comment.
Reviewed 630 of 630 files at r1, 60 of 60 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL), "fixup! " found in commit messages' one-liners (waiting on @boryspoplawski)
a discussion (no related file):
I think we should also update CONTRIBUTING.rst - it now says "Should include which component was changed (Pal-{Linux,SGX} / LibOS / Docs / CI)" - we probably want to say now "PAL"? That's the correct casing of this component name, we used "Pal" only because of that weird directory name.
There was a problem hiding this comment.
Reviewable status: 659 of 660 files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL), "fixup! " found in commit messages' one-liners (waiting on @mkow)
a discussion (no related file):
Previously, mkow (Michał Kowalczyk) wrote…
I think we should also update
CONTRIBUTING.rst- it now says "Should include which component was changed (Pal-{Linux,SGX} / LibOS / Docs / CI)" - we probably want to say now "PAL"? That's the correct casing of this component name, we used "Pal" only because of that weird directory name.
Yeah, I even found this while changing, idk what happened...
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: ITL), "fixup! " found in commit messages' one-liners
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: all files reviewed, all discussions resolved, "fixup! " found in commit messages' one-liners
Signed-off-by: Borys Popławski <[email protected]>
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Description of the changes
I've split the commit in two parts (2nd is a fixup for convenience of merging):
X- capital x - to mark all files as reviewed and then the big button at the top "next unreviewed diff").I changed the mode to commit-by-commit review, so above should be easy.
Well, if you are brave enough, don't use reviewable at all - it doesn't handle so many files well.
How to test this PR?
CI should be enough.
This change is