[Pal/Linux-SGX] Add MAA to RA-TLS and SecretProv libs #652

dimakuv · 2022-06-14T13:27:11Z

Description of the changes

Microsoft Azure Attestation (MAA) is a new attestation scheme available in the MS Azure public cloud. It uses the classic DCAP SGX quotes but replaces the DCAP/EPID quote-verification software infrastructure with the new MAA attestation provider infrastructure. In particular, the remote user is supposed to send the SGX quote in the HTTPS REST attestation request to the MAA attestation provider and receive back the JSON Web Token (JWT) that contains claims about the attesting SGX enclave.

This commit introduces new _maa versions of the RA-TLS and Secret Provisioning verification libraries. The documentation and the ra-tls-mbedtls and ra-tls-secret-prov examples are updated.

For design, see #626.

This PR does not depend on any other PRs, but as part of this work I detected and fixed some attestation-related issues:

How to test this PR?

Manually verified on a MS Azure CC VM, with the https://sharedcus.cus.attest.azure.net default attestation provider. See the READMEs of ra-tls-mbedtls and ra-tls-secret-prov examples.

This change is

AI-Memory · 2022-07-12T02:28:59Z

CI-Examples/ra-tls-mbedtls/src/client.c

+        ra_tls_verify_lib = dlopen("libra_tls_verify_maa.so", RTLD_LAZY);
+        if (!ra_tls_verify_lib) {
+            mbedtls_printf("%s\n", dlerror());
+            mbedtls_printf("User requested RA-TLS verification with MAA but cannot find lib\n");


Could be more specific in this context.
For example. "User requested RA-TLS verification with MAA but cannot find helper libra_tls_verify_maa.so lib.\n"

AI-Memory · 2022-07-12T02:34:24Z

CI-Examples/ra-tls-mbedtls/src/client.c

+            return 1;
+        }
+
+        ra_tls_verify_lib = dlopen("libra_tls_verify_maa.so", RTLD_LAZY);


Suggest using a const char* to hold the name of this external library for reuse in message if possible.

dimakuv

Reviewable status: 0 of 22 files reviewed, 2 unresolved discussions, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @bigdata-memory)

CI-Examples/ra-tls-mbedtls/src/client.c line 212 at r1 (raw file):

Previously, bigdata-memory (Gordon King) wrote…

Suggest using a const char* to hold the name of this external library for reuse in message if possible.

Don't see a need.

CI-Examples/ra-tls-mbedtls/src/client.c line 215 at r1 (raw file):

Previously, bigdata-memory (Gordon King) wrote…

Could be more specific in this context.
For example. "User requested RA-TLS verification with MAA but cannot find helper libra_tls_verify_maa.so lib.\n"

Done.

Microsoft Azure Attestation (MAA) is a new attestation scheme available in the MS Azure public cloud. It uses the classic DCAP SGX quotes but replaces the DCAP/EPID quote-verification software infrastructure with the new MAA attestation provider infrastructure. In particular, the remote user is supposed to send the SGX quote in the HTTPS REST attestation request to the MAA attestation provider and receive back the JSON Web Token (JWT) that contains claims about the attesting SGX enclave. This commit introduces new `_maa` versions of the RA-TLS and Secret Provisioning verification libraries. MAA attestation should be enabled via `sgx.remote_attestation = "maa"` (`RA_TYPE=maa` in Makefiles). The documentation and the `ra-tls-mbedtls` and `ra-tls-secret-prov` examples are updated. Signed-off-by: Dmitrii Kuvaiskii <[email protected]>

dimakuv

Reviewable status: 0 of 22 files reviewed, 2 unresolved discussions, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @bigdata-memory)

a discussion (no related file):
FYI: Tested again using:

Busybox (just checking /dev/attestation)
Python (using sgx-quote.py)
ra-tls-mbedtls: RA_TYPE="maa" RA_TLS_ALLOW_DEBUG_ENCLAVE_INSECURE=1 RA_TLS_MAA_PROVIDER_URL="https://sharedcus.cus.attest.azure.net" make check_maa
ra-tls-mbedtls failure: RA_TYPE="maa" RA_TLS_ALLOW_DEBUG_ENCLAVE_INSECURE=1 RA_TLS_MAA_PROVIDER_URL="https://sharedcus.cus.attest.azure.net" make check_maa_fail
ra-tls-secret-prov: RA_TYPE="maa" RA_TLS_ALLOW_DEBUG_ENCLAVE_INSECURE=1 RA_TLS_MAA_PROVIDER_URL="https://sharedcus.cus.attest.azure.net" make check_maa

Everything works fine. I also GDB'd just to make sure the correct flows are being executed.

xiangyuT · 2022-11-03T07:18:34Z

Hi @dimakuv, I want to know when will this PR be merged and before it's merged, if we can and how we can do MAA in Gramine?

dimakuv · 2022-11-03T09:27:38Z

@xiangyuT

I want to know when will this PR be merged...

Hard to say, but in upcoming 1-2 months I think. It depends on the review process. Which is a good opportunity to ping @mkow :)

...before it's merged, if we can and how we can do MAA in Gramine?

You can use this PR (this branch) to test MAA with Gramine. There is documentation included in this PR. Or maybe you meant something else?

xiangyuT · 2022-11-07T08:49:46Z

@dimakuv
Got it. I will try this branch to test MAA. Thanks!

mkow

Which is a good opportunity to ping @mkow :)

ITL is still waiting to get an Azure instance from either Intel or MS, otherwise we can't even test this PR. Also, what about CI? ;)

Reviewable status: 0 of 22 files reviewed, 2 unresolved discussions, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @bigdata-memory)

dimakuv

@mkow I can give you access to my Azure VM with Ubuntu 20.04 for testing. Do you want that?

Regarding CI: I don't have a good idea. I also don't have a good idea how MAA can be split as some kind of "plugin" from the rest of RA-TLS code...

Reviewable status: 0 of 22 files reviewed, 2 unresolved discussions, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @bigdata-memory)

RodgerZhu · 2023-02-08T04:28:00Z

Hi @dimakuv, any latest updates about this PR?
We are now working on Azure SGX instance with Gramine and this MAA requirement is blocking us.
Hopefully Gramine can support MAA soon then Azure end-users can deploy solutions with Gramine in Azure cloud without any blocking.

dimakuv · 2023-02-08T08:49:56Z

@RodgerZhu Short answer is that this PR is pending on #1114.

I.e., Gramine first needs to have a proper plugin architecture for external attestation schemes (like MAA), and then I'll refactor this PR to become a plugin.

The timeline is uncertain for this feature...

dimakuv marked this pull request as draft June 14, 2022 13:27

dimakuv force-pushed the dimakuv/ra-tls-maa branch from dd2f3e2 to c23b380 Compare June 14, 2022 14:00

dimakuv mentioned this pull request Jun 14, 2022

[Pal/Linux-SGX] RFC: Support for Microsoft Azure Attestation #626

Closed

8 tasks

dimakuv force-pushed the dimakuv/ra-tls-maa branch from c23b380 to 3abc5f0 Compare June 15, 2022 13:31

dimakuv marked this pull request as ready for review June 15, 2022 13:52

AI-Memory reviewed Jul 12, 2022

View reviewed changes

dimakuv mentioned this pull request Aug 5, 2022

[SGX] RFC: Support for Intel Project Amber Attestation #822

Closed

dimakuv force-pushed the dimakuv/ra-tls-maa branch 2 times, most recently from 9354acc to 60fcb1a Compare October 14, 2022 12:31

dimakuv commented Oct 14, 2022

View reviewed changes

dimakuv force-pushed the dimakuv/ra-tls-maa branch from 60fcb1a to 4673d90 Compare October 14, 2022 13:11

dimakuv force-pushed the dimakuv/ra-tls-maa branch from 4673d90 to a216621 Compare October 14, 2022 13:22

dimakuv commented Oct 14, 2022

View reviewed changes

mkow reviewed Nov 10, 2022

View reviewed changes

dimakuv commented Nov 11, 2022

View reviewed changes

dimakuv mentioned this pull request Dec 1, 2022

[RA-TLS] Introduce plugin architecture #1071

Closed

This was referenced Mar 7, 2023

[tools/sgx,meson,packaging] Bug fixes for RA-TLS plugins #1218

Merged

[Integrations/azure] Add RA-TLS/SecretProv libs for MAA gramineproject/contrib#38

Merged

dimakuv closed this in gramineproject/contrib#38 Sep 25, 2023

dimakuv deleted the dimakuv/ra-tls-maa branch November 2, 2023 07:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Pal/Linux-SGX] Add MAA to RA-TLS and SecretProv libs #652

[Pal/Linux-SGX] Add MAA to RA-TLS and SecretProv libs #652

dimakuv commented Jun 14, 2022 •

edited

Loading

AI-Memory Jul 12, 2022

AI-Memory Jul 12, 2022

dimakuv left a comment

dimakuv left a comment

xiangyuT commented Nov 3, 2022

dimakuv commented Nov 3, 2022

xiangyuT commented Nov 7, 2022

mkow left a comment

dimakuv left a comment

RodgerZhu commented Feb 8, 2023 •

edited

Loading

dimakuv commented Feb 8, 2023

[Pal/Linux-SGX] Add MAA to RA-TLS and SecretProv libs #652

[Pal/Linux-SGX] Add MAA to RA-TLS and SecretProv libs #652

Conversation

dimakuv commented Jun 14, 2022 • edited Loading

Description of the changes

How to test this PR?

AI-Memory Jul 12, 2022

Choose a reason for hiding this comment

AI-Memory Jul 12, 2022

Choose a reason for hiding this comment

dimakuv left a comment

Choose a reason for hiding this comment

dimakuv left a comment

Choose a reason for hiding this comment

xiangyuT commented Nov 3, 2022

dimakuv commented Nov 3, 2022

xiangyuT commented Nov 7, 2022

mkow left a comment

Choose a reason for hiding this comment

dimakuv left a comment

Choose a reason for hiding this comment

RodgerZhu commented Feb 8, 2023 • edited Loading

dimakuv commented Feb 8, 2023

dimakuv commented Jun 14, 2022 •

edited

Loading

RodgerZhu commented Feb 8, 2023 •

edited

Loading