-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Examples] Remove big examples from this repository #4
Conversation
Signed-off-by: Dmitrii Kuvaiskii <[email protected]>
The following examples are moved to a separate repository https://github.com/gramineproject/examples: Apache, Curl, GCC, Node.js, OpenJDK (Java), OpenVINO, PyTorch, R, TensorFlow-Lite. Only sufficiently small and useful examples are kept in this repo (Bash, Blender, BusyBox, Lighttpd, Memcached, Nginx, Python, RA-TLS, Redis, SQLite). All these kept examples are included in our Jenkins CI. Signed-off-by: Dmitrii Kuvaiskii <[email protected]>
Previous commit removed big/unused examples from this repo. Now we only keep examples that are run in our Jenkins CI, so we rename the directory to reflect this. Signed-off-by: Dmitrii Kuvaiskii <[email protected]>
2d8a8a7
to
05f7b38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 141 files at r1, 6 of 7 files at r2.
Reviewable status: 7 of 145 files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @dimakuv)
a discussion (no related file):
Blocking until we create https://github.com/gramineproject/examples.
05f7b38
to
b98d4c6
Compare
Jenkins, retest Jenkins-18.04 please ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 137 of 141 files at r1, 1 of 7 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
b98d4c6
to
e108676
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
Jenkins, retest Jenkins-20.04 please ( |
Jenkins, retest DCO please |
Jenkins, retest Docs-18.04 please |
e108676
to
4321ecf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
Description of the changes
The following examples are moved to a separate repository https://github.com/gramineproject/examples: Apache, Curl, GCC, Node.js, OpenJDK (Java), OpenVINO, PyTorch, R, TensorFlow-Lite.
Only sufficiently small and useful examples are kept in this repo (Bash, Blender, BusyBox, Lighttpd, Memcached, Nginx, Python, RA-TLS, Redis, SQLite). All these kept examples are included in our Jenkins CI.
As side commits, I also:
oldwiki/
page from documentationExamples/
toCI-Examples/
See gramineproject/graphene#2558 for context.
How to test this PR?
N/A.
This change is