Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Examples] Remove big examples from this repository #4

Merged
merged 3 commits into from
Sep 15, 2021

Conversation

dimakuv
Copy link

@dimakuv dimakuv commented Sep 9, 2021

Description of the changes

The following examples are moved to a separate repository https://github.com/gramineproject/examples: Apache, Curl, GCC, Node.js, OpenJDK (Java), OpenVINO, PyTorch, R, TensorFlow-Lite.

Only sufficiently small and useful examples are kept in this repo (Bash, Blender, BusyBox, Lighttpd, Memcached, Nginx, Python, RA-TLS, Redis, SQLite). All these kept examples are included in our Jenkins CI.

As side commits, I also:

  • Removed stale and unused oldwiki/ page from documentation
  • Renamed Examples/ to CI-Examples/

See gramineproject/graphene#2558 for context.

How to test this PR?

N/A.


This change is Reviewable

Dmitrii Kuvaiskii added 3 commits September 6, 2021 14:12
The following examples are moved to a separate repository
https://github.com/gramineproject/examples: Apache, Curl, GCC, Node.js,
OpenJDK (Java), OpenVINO, PyTorch, R, TensorFlow-Lite.

Only sufficiently small and useful examples are kept in this repo (Bash,
Blender, BusyBox, Lighttpd, Memcached, Nginx, Python, RA-TLS, Redis,
SQLite). All these kept examples are included in our Jenkins CI.

Signed-off-by: Dmitrii Kuvaiskii <[email protected]>
Previous commit removed big/unused examples from this repo. Now we only
keep examples that are run in our Jenkins CI, so we rename the directory
to reflect this.

Signed-off-by: Dmitrii Kuvaiskii <[email protected]>
Copy link
Member

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 141 files at r1, 6 of 7 files at r2.
Reviewable status: 7 of 145 files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @dimakuv)

a discussion (no related file):
Blocking until we create https://github.com/gramineproject/examples.


@dimakuv
Copy link
Author

dimakuv commented Sep 9, 2021

Jenkins, retest Jenkins-18.04 please (apps.LTP.fcntl14 timed out)

mkow
mkow previously approved these changes Sep 14, 2021
Copy link
Member

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 137 of 141 files at r1, 1 of 7 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

mkow
mkow previously approved these changes Sep 14, 2021
Copy link
Member

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mkow
Copy link
Member

mkow commented Sep 15, 2021

Jenkins, retest Jenkins-20.04 please (sendfile09_64 from LTP failed, wasn't seen before, but this is quite a slow test and unrelated to this PR)

@dimakuv
Copy link
Author

dimakuv commented Sep 15, 2021

Jenkins, retest DCO please

@dimakuv
Copy link
Author

dimakuv commented Sep 15, 2021

Jenkins, retest Docs-18.04 please

Copy link
Member

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mkow mkow merged commit 4321ecf into master Sep 15, 2021
@mkow mkow deleted the dimakuv/rm-heavy-examples branch September 15, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants