Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSC] Remove GSC tool and its documentation from this repository #3

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

dimakuv
Copy link

@dimakuv dimakuv commented Sep 9, 2021

Description of the changes

GSC (Gramine Schielded Containers) is moved to a separate repository https://github.com/gramineproject/gsc.

See gramineproject/graphene#2558 for context.

How to test this PR?

N/A.


This change is Reviewable

GSC (Gramine Shielded Containers) is moved to a separate repository:
https://github.com/gramineproject/gsc.

Signed-off-by: Dmitrii Kuvaiskii <[email protected]>
Copy link
Member

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 34 of 34 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @dimakuv)

a discussion (no related file):
Blocking until we actually create https://github.com/gramineproject/gsc.



-- commits, line 4 at r1:
Schielded -> Shielded

Copy link
Member

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@boryspoplawski boryspoplawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 34 of 34 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mkow mkow merged commit d1fd49a into master Sep 16, 2021
@mkow mkow deleted the dimakuv/rm-gsc branch September 16, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants