[LibOS] Do not flush unopened Encrypted File during checkpoint

Without this check, the called `encrypted_file_flush(enc)` assumes that the Encrypted File is opened and fails on an assert / with a segfault because it tries to access `enc->pf`. Kudos to Anees Sahib <[email protected]> for root causing the bug. Signed-off-by: Dmitrii Kuvaiskii <[email protected]>
gramineproject · Jun 20, 2022 · 63d8dca · 63d8dca
1 parent 6f82e17
commit 63d8dca
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/LibOS/src/fs/shim_fs_encrypted.c b/LibOS/src/fs/shim_fs_encrypted.c
@@ -739,9 +739,11 @@ BEGIN_CP_FUNC(encrypted_file) {
     struct shim_encrypted_file* enc = obj;
     struct shim_encrypted_file* new_enc = NULL;
 
-    int ret = encrypted_file_flush(enc);
-    if (ret < 0)
-        return ret;
+    if (enc->pf) {
+        int ret = encrypted_file_flush(enc);
+        if (ret < 0)
+            return ret;
+    }
 
     size_t off = ADD_CP_OFFSET(sizeof(struct shim_encrypted_file));
     new_enc = (struct shim_encrypted_file*)(base + off);