4) rust -os flag #1076
Merged
4) rust -os flag #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crop2000
force-pushed
the
rust_os
branch
3 times, most recently
from
58ad9d6
to
a4798f3
Compare
crop2000
force-pushed
the
rust_os
branch
4 times, most recently
from
36d3e64
to
38aecba
Compare
|
@sletz finally this passes the tests too, so it is ready. |
sletz
reviewed
Nov 29, 2024
sletz
reviewed
Nov 29, 2024
| { | ||
| tab(n, *fOut); | ||
| tab(n, *fOut); | ||
| *fOut << "pub fn compute_frame(&mut self, inputs: &[&FaustFloat], "; |
There was a problem hiding this comment.
Can you use frame instead of compute_frame to be similar to what C and C++ already generate ?
There was a problem hiding this comment.
i prefer compute_frame because it makes clearer that it is a variant of compute.
crop2000
force-pushed
the
rust_os
branch
5 times, most recently
from
9dbbf09
to
b4bdcfa
Compare
|
@sletz i changed this pr and also tested cpp with -os in ci |
|
Thanks, merged, with the "public" function renaming and different fix in the tests (make c/make cpp were broken). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.