feat: add debugger support#37
Merged
Merged
Conversation
Contributor
Author
|
I've only tested it locally on linux so it would need some testing on MacOS and Windows to make sure everything works |
Collaborator
julienduchesne
left a comment
julienduchesne
left a comment
There was a problem hiding this comment.
Wow, looks amazing. Can we do the reformatting in a different PR, with an editorconfig if possible?
Contributor
Author
|
Opened #38 to get to consistent formatting. Will rebase this after it's merged. |
theSuess
force-pushed
the
feat/add-debugger
branch
from
de0b2d5 to
c1a2f74
Compare
julienduchesne
approved these changes
Feb 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements support for debugging jsonnet files based on google/go-jsonnet#739.
The installation works the same way as the language server. By default, the following repository is used: https://github.com/grafana/jsonnet-debugger
The current checked in files were formatted inconsistently, that's why there's such a large diff.
Summarized Changes: