chore: update otel deps to v1.52#6524
Conversation
javiermolinar
requested review from
carles-grafana,
electron0zero,
ie-pham,
mapno,
mattdurham,
mdisibio,
oleg-kozlyuk-grafana,
ruslan-mikhailov,
stoewer,
yvrhdn and
zalegrala
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7452d56f51
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| go.opentelemetry.io/collector/exporter v1.52.0 | ||
| go.opentelemetry.io/collector/exporter/exporterhelper v0.146.1 | ||
| go.opentelemetry.io/collector/exporter/exportertest v0.146.1 | ||
| go.opentelemetry.io/collector/exporter/otlpexporter v0.146.1 |
There was a problem hiding this comment.
Upgrading go.opentelemetry.io/collector/exporter/otlpexporter to v0.146.1 pulls in a start path that calls component.Host.GetExtensions(), but modules/distributor/receiver/shim_test.go still has mockHost.GetExtensions() as panic("implement me"), so TestShim_integration now panics immediately when the exporter starts (reproduced with go test ./modules/distributor/receiver -run TestShim_integration). Please update the test host implementation alongside this dependency bump so CI can execute the receiver integration tests.
Useful? React with 👍 / 👎.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
zalegrala
left a comment
zalegrala
left a comment
There was a problem hiding this comment.
This looks reasonable to me.
* chore: update otel deps to v1.52 * return empty map for getExtensions * add otelProtomesage to gogocodec * revert changes in the tools module caused by Codex
* chore: update otel deps to v1.52 * return empty map for getExtensions * add otelProtomesage to gogocodec * revert changes in the tools module caused by Codex
* chore: update otel deps to v1.52 * return empty map for getExtensions * add otelProtomesage to gogocodec * revert changes in the tools module caused by Codex
3 participants
What this PR does:
There are two dependabots pr that are stuck:
#6321
#6320
This one fixes all the issues and breaking changes
OpenTelemetry Collector switched OTLP payloads to its own internal proto encoder instead of relying on the gogo path, so we updated gogocodec to recognize that interface and handle those messages correctly
open-telemetry/opentelemetry-collector#14078
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]