Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dskit to the version without log.Interface and logrus #2796

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Upgrade dskit to the version without log.Interface and logrus #2796

wants to merge 1 commit into from

Conversation

duricanikolic
Copy link

@duricanikolic duricanikolic commented Aug 16, 2023 •
edited
Loading

What this PR does:
This PR upgrades dskit and uses dskit's log package for the creation of the global logger.
For the main in the dskit see grafana/dskit#359.

Moreover, it removes RateLimitedLogger from tempo and replaces it with dskit's equivalent.

Checklist

  • Tests updated
  • [n/a] Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@duricanikolic duricanikolic self-assigned this Aug 16, 2023
@CLAassistant
Copy link

CLAassistant commented Aug 16, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@duricanikolic duricanikolic force-pushed the yuri/dskit-log branch 2 times, most recently from eae92a4 to ec493a2 Compare August 16, 2023 14:55
@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had any activity in the past 60 days.
The next time this stale check runs, the stale label will be removed if there is new activity. This pull request will be closed in 15 days if there is no new activity.
Please apply keepalive label to exempt this Pull Request.

@github-actions github-actions bot added the stale Used for stale issues / PRs label Oct 17, 2023
@duricanikolic duricanikolic added the keepalive Label to exempt Issues / PRs from stale workflow label Oct 17, 2023
@github-actions github-actions bot removed the stale Used for stale issues / PRs label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-elliott joe-elliott Awaiting requested review from joe-elliott joe-elliott will be requested when the pull request is marked ready for review joe-elliott is a code owner

@mdisibio mdisibio Awaiting requested review from mdisibio mdisibio will be requested when the pull request is marked ready for review mdisibio is a code owner

@mapno mapno Awaiting requested review from mapno mapno will be requested when the pull request is marked ready for review mapno is a code owner

@yvrhdn yvrhdn Awaiting requested review from yvrhdn yvrhdn will be requested when the pull request is marked ready for review yvrhdn is a code owner

@zalegrala zalegrala Awaiting requested review from zalegrala zalegrala will be requested when the pull request is marked ready for review zalegrala is a code owner

@electron0zero electron0zero Awaiting requested review from electron0zero electron0zero will be requested when the pull request is marked ready for review electron0zero is a code owner

@ie-pham ie-pham Awaiting requested review from ie-pham ie-pham will be requested when the pull request is marked ready for review ie-pham is a code owner

@stoewer stoewer Awaiting requested review from stoewer stoewer will be requested when the pull request is marked ready for review stoewer is a code owner

@javiermolinar javiermolinar Awaiting requested review from javiermolinar javiermolinar will be requested when the pull request is marked ready for review javiermolinar is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@duricanikolic duricanikolic

Labels
keepalive Label to exempt Issues / PRs from stale workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duricanikolic @CLAassistant