Skip to content

Continuously deploy main branch to dev env - #1158

Merged
annanay25 merged 5 commits into
grafana:mainfrom
annanay25:cd-for-dev-env
Dec 10, 2021
Merged

annanay25 merged 5 commits into
grafana:mainfrom
annanay25:cd-for-dev-env

Conversation

@annanay25

@annanay25 annanay25 commented Dec 7, 2021

Copy link
Copy Markdown
Contributor

Signed-off-by: Annanay annanayagarwal@gmail.com

What this PR does:
This PR sets up a continuous deployment pipeline so every merge to main branch is deployed to our dev cluster. This ensures a quick feedback loop for changes.

Changes are primarily based on grafana-cold-storage/agent#1103

Which issue(s) this PR fixes:
Fixes nothing!

Checklist

  • NA Tests updated
  • Documentation added
  • NA CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Annanay <annanayagarwal@gmail.com>
Comment thread .drone/drone.yml Outdated

@yvrhdn yvrhdn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looking forward to see this in action! Left a couple of comments.

Comment thread .drone/drone.jsonnet Outdated
Comment thread .drone/drone.jsonnet Outdated
Comment thread .drone/drone.jsonnet
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Comment thread .drone/drone.yml Outdated
Comment thread Makefile
@annanay25
annanay25 requested a review from yvrhdn December 8, 2021 08:06

@yvrhdn yvrhdn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a couple more comments but I'll already approve so you can merge at will.

Comment thread .drone/drone.jsonnet Outdated
Comment thread .drone/drone.yml Outdated
Comment thread .drone/drone.yml Outdated

@jvrplmlmn jvrplmlmn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did a very quick pass, I haven't looked too much in detail but this LG2M!

Signed-off-by: Annanay <annanayagarwal@gmail.com>
@annanay25
annanay25 requested a review from zalegrala as a code owner December 10, 2021 06:45
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
@annanay25

Copy link
Copy Markdown
Contributor Author

Merging this PR, the failing integration test is unrelated. :(

@annanay25
annanay25 merged commit 695ff62 into grafana:main Dec 10, 2021
mattdurham pushed a commit to mattdurham/tempo that referenced this pull request Jun 18, 2026
* Continuously deploy main branch to dev env

Signed-off-by: Annanay <annanayagarwal@gmail.com>

* Address comments

Signed-off-by: Annanay <annanayagarwal@gmail.com>

* Use std.manifestJsonEx

Signed-off-by: Annanay <annanayagarwal@gmail.com>

* update yml and signature

Signed-off-by: Annanay <annanayagarwal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants