Skip to content

Commit

Permalink
Add pprof flag to optionally expose pprof data (#590)
Browse files Browse the repository at this point in the history
Resolves: #242
  • Loading branch information
andreasgerstmayr authored Sep 5, 2023
1 parent 84c0ea1 commit e0c7ad4
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 1 deletion.
16 changes: 16 additions & 0 deletions .chloggen/pprof.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement

# The name of the component, or a single word describing the area of concern, (e.g. operator, github action)
component: operator

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Add pprof flag to optionally expose pprof data

# One or more tracking issues related to the change
issues: [242]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:
6 changes: 5 additions & 1 deletion cmd/start/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ func start(c *cobra.Command, args []string) {
setupLog := ctrl.Log.WithName("setup")
version := version.Get()

options.PprofBindAddress, _ = c.Flags().GetString("pprof-addr")

mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), options)
if err != nil {
setupLog.Error(err, "unable to start manager")
Expand Down Expand Up @@ -136,9 +138,11 @@ func addDependencies(mgr ctrl.Manager, ctrlConfig configv1alpha1.ProjectConfig,

// NewStartCommand returns a new start command.
func NewStartCommand() *cobra.Command {
return &cobra.Command{
cmd := &cobra.Command{
Use: "start",
Short: "Start the Tempo operator",
Run: start,
}
cmd.Flags().String("pprof-addr", "", "The address the pprof server binds to. Default is empty string which disables the pprof server.")
return cmd
}

0 comments on commit e0c7ad4

Please sign in to comment.