Conversation
With this it should be possible to keep track of performance issues also when called from wrapper tools. This tries to adhere to the environment specification laid out in open-telemetry/opentelemetry-specification#4454
Contributor
|
1be56a3 to
e40cd33
Compare
guicaulada
approved these changes
Aug 28, 2025
Member
guicaulada
left a comment
There was a problem hiding this comment.
A lot of ctx but seems like a simple change despite the number of lines and files changed.
Thank you for working on this, this feat must have felt like a chore to work on.
LGTM!
Contributor
Author
|
@guicaulada Thanks 🙂 It was actually fun since I finally was able to implement the env var propagation as that's finally formalized 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal here is to be able to track down and visualize performance issues esp. when duing exports. This should also work if used within a wrapper that also works with OpenTelemetry.