-
Notifications
You must be signed in to change notification settings - Fork 29
feat(go-flaky-tests): add github issue management #1276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(go-flaky-tests): add github issue management #1276
Conversation
|
Very cool! Haven't reviewed the code but wanted to ask if you've demo'd this or announced it in the engineering weekly. I think this workflow could be handy for lots of repositories! |
good shout. Not yet, but @dsotirakis also suggested a conference talk. So some sort of talk should happen. |
zerok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add yourself (or your team) as codeowners for that action 🙂
guicaulada
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, just missing the CODEOWNERS change as Horst mentioned 🙂
|
oh sorry i had missed this comment. Pushed a change |
Complete the flaky test action with full GitHub integration: - Add GitHub client implementation for issue management - Create and update GitHub issues for flaky tests - Search for existing issues to avoid duplicates - Automatically reopen closed issues when tests fail again - Rich issue templates with investigation guides and author mentions - GitHub CLI integration for all operations - Add github-token and skip-posting-issues config options Builds on PR2's Git author tracking with complete GitHub workflow. This completes the full analyze-test-failures action functionality.
This reverts commit 97c3804.
# Conflicts: # actions/go-flaky-tests/cmd/go-flaky-tests/analyzer.go
This reverts commit d660967.
f5b7c66 to
d7b015f
Compare
|
@zerok do you want to wait for another review from @guicaulada or @dsotirakis or can we merge? I don't have the permissions to merge |
Summary
Completes the flaky test detection system from dimitarvdimitrov#2 by adding comprehensive GitHub issue management. This enables automatic creation and updating of issues for flaky tests.
This is the last of 3 PRs for go-flaky-tests. (continued from #1029)
What's Added
GitHubClientimplementation using GitHub CLIKey Components
github.go: Complete GitHub operations with proper error handling and issue lifecycle management. The GitHub integration uses the GitHub CLI (gh) for all operationsanalyzer.go: Full implementation of issue creation and preview functionalitygithub-tokeninput parameter andskip-posting-issuescontrol