refactor(lint-pr-title): modernise Dockerfile #1121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerok
reviewed
Jul 10, 2025
| WORKDIR /home/newuser/app | ||
| COPY --from=install /home/newuser/temp/dev/node_modules ./node_modules | ||
| COPY --chown=newuser:newuser . . | ||
| RUN --mount=type=cache,target=/root/.bun/install/cache \ |
Contributor
There was a problem hiding this comment.
Would it perhaps make sense to have the cache filled only with production dependencies and then another one that is filled with dev dependencies for the test run?
Member
Author
There was a problem hiding this comment.
One cache makes sense to me, enables things to be shared, moved around when needed
The previous Dockerfile was overly complex and inefficient, a result of adapting an older style to a workspace environment. The multi-stage build was difficult to read and did not use modern Docker features for caching. To fix these problems, we simplify the build process into a more readable multi-stage build. We introduce Docker cache mounts for dependency installation, which will result in significantly faster builds. The COPY commands are now more specific to avoid copying unnecessary files into the image. Tests continue to be run as a non-root user to ensure file permission tests work correctly, but in a more streamlined way.
iainlane
force-pushed
the
iainlane/refactor-lint-pr-title-dockerfile
branch
from
da7e82b to
dff68fd
Compare
zerok
approved these changes
Jul 15, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 17, 2025
) * fix(lint-pr-title): adapt action and Dockerfile to bun workspaces The lint-pr-title action was failing to run correctly after the migration to bun workspaces in 9ffb9ce. This was due to two issues: 1. The composite action was not checking out the shared-workflows repository, so the workspace dependencies could not be installed. 2. The Dockerfile was not adapted to the workspace structure, and the tests were failing due to file permission issues. This commit addresses both issues. The action.yml now checks out the shared-workflows repository, following the pattern of other actions in this repository. The Dockerfile is updated to correctly build in a workspace context and to run the tests as a non-root user to ensure file permission tests pass. It sort of kept working because we forgot to remove the bun.lock file in `actions/lint-pr-title.` This papered over the problem until a Bun update needed to update the lock file and it stopped working. Here we remove that. Now that we use files outside of the action's own directory (`package.json`, `bun.lock`), we need to check the repository out and run from the root. * refactor(lint-pr-title): modernise Dockerfile (#1121) The previous Dockerfile was overly complex and inefficient, a result of adapting an older style to a workspace environment. The multi-stage build was difficult to read and did not use modern Docker features for caching. To fix these problems, we simplify the build process into a more readable multi-stage build. We introduce Docker cache mounts for dependency installation, which will result in significantly faster builds. The COPY commands are now more specific to avoid copying unnecessary files into the image. Tests continue to be run as a non-root user to ensure file permission tests work correctly, but in a more streamlined way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is stacked on #1120
The previous Dockerfile was overly complex and inefficient, a result of adapting an older style to a workspace environment. The multi-stage build was difficult to read and did not use modern Docker features for caching.
To fix these problems, we simplify the build process into a more readable multi-stage build. We introduce Docker cache mounts for dependency installation, which will result in significantly faster builds. The COPY commands are now more specific to avoid copying unnecessary files into the image. Tests continue to be run as a non-root user to ensure file permission tests work correctly, but in a more streamlined way.