Skip to content

Support pyston based environment#3126

Merged
korniltsev merged 4 commits intografana:mainfrom
keyolk:support-pyston
Apr 2, 2024
Merged

Support pyston based environment#3126
korniltsev merged 4 commits intografana:mainfrom
keyolk:support-pyston

Conversation

@keyolk
Copy link
Copy Markdown
Contributor

@keyolk keyolk commented Mar 21, 2024

Fix #3125

@keyolk keyolk requested a review from korniltsev as a code owner March 21, 2024 02:47
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 21, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 21, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@keyolk keyolk mentioned this pull request Mar 21, 2024
Closed
@keyolk keyolk force-pushed the support-pyston branch 2 times, most recently from 2350d2d to 2da505a Compare March 21, 2024 02:49
@korniltsev
Copy link
Copy Markdown
Contributor

korniltsev commented Apr 1, 2024

Thanks for the fix!
Does profiling work after these patches?
Please fix CI.
You may need to add binaries to this git submodule https://github.com/pyroscope-io/pyroscope-ebpf-testdata

@keyolk
Copy link
Copy Markdown
Contributor Author

keyolk commented Apr 2, 2024

@korniltsev Yes, it is working on our prod env. I'll update this PR : )

keyolk added 3 commits April 2, 2024 16:57
@keyolk @gavin-jeong
Support pyston based environment
4c16604 
Signed-off-by: Chanhun Jeong <keyolk@gmail.com>
@keyolk @gavin-jeong
Update test
cb6191e 
Signed-off-by: Chanhun Jeong <keyolk@gmail.com>
@keyolk @gavin-jeong
Update submodule
43d828f 
Signed-off-by: Chanhun Jeong <keyolk@gmail.com>
@korniltsev korniltsev enabled auto-merge (squash) April 2, 2024 08:12
@keyolk @gavin-jeong
Fix test
f417605 
Signed-off-by: Chanhun Jeong <keyolk@gmail.com>
auto-merge was automatically disabled April 2, 2024 08:28

Head branch was pushed to by a user without write access

@korniltsev korniltsev enabled auto-merge (squash) April 2, 2024 09:35
@korniltsev korniltsev merged commit f4dd4b7 into grafana:main Apr 2, 2024
@korniltsev
Copy link
Copy Markdown
Contributor

korniltsev commented Apr 2, 2024

Thanks!

@korniltsev korniltsev mentioned this pull request May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@korniltsev korniltsev korniltsev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pyperf profiling not working with pyston environment

3 participants

@keyolk @CLAassistant @korniltsev