fix(build): freeze x/exp dependency #2701
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slices.SortFunc
from the experimentalgolang.org/x/exp
has changed its signature which breaks in our code, and in dependencies:golang/exp@302865e
See https://github.com/grafana/pyroscope/actions/runs/6886513285/job/18732588802?pr=2700.
This is a quick fix: I've pinned the latest compatible version of
x/exp
. We should probably get rid of the dependency and update to Go 1.21 (which has built-inslices
package)Also had to pin
x/sys
in ebpf submodule due to golang/go#63969