Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): freeze x/exp dependency #2701

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Conversation

kolesnikovae
Copy link
Collaborator

@kolesnikovae kolesnikovae commented Nov 16, 2023

slices.SortFunc from the experimental golang.org/x/exp has changed its signature which breaks in our code, and in dependencies:

golang/exp@302865e

Note that this changes some of the sorting functions to use a
comparison function rather than a less function. We don't promise
backward compatibility in x/exp packages. Being compatible with the
Go 1.21 package seems more useful for people not yet using 1.21,
as it will make the transition to 1.21 easier.

See https://github.com/grafana/pyroscope/actions/runs/6886513285/job/18732588802?pr=2700.

This is a quick fix: I've pinned the latest compatible version of x/exp. We should probably get rid of the dependency and update to Go 1.21 (which has built-in slices package)

Also had to pin x/sys in ebpf submodule due to golang/go#63969

@kolesnikovae kolesnikovae requested a review from a team as a code owner November 16, 2023 06:27
@kolesnikovae
Copy link
Collaborator Author

/cc @korniltsev please take another look: 1e437f0 - turns out x/sys 0.14 is broken as well

@kolesnikovae kolesnikovae merged commit 07bd492 into main Nov 16, 2023
17 checks passed
@kolesnikovae kolesnikovae deleted the fix/go-exp-compatibility branch November 16, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants