Skip to content

fix: support current upstream Java instrumentation list format#280

Merged
zeitlinger merged 1 commit intomainfrom
fix/java-supported-libraries
Apr 21, 2026
Merged

fix: support current upstream Java instrumentation list format#280
zeitlinger merged 1 commit intomainfrom
fix/java-supported-libraries

Conversation

@zeitlinger
Copy link
Copy Markdown
Member

Summary

  • update the Java supported-library loader to handle the current upstream instrumentation-list.yaml list format
  • keep compatibility with the older mapped representation used internally by otel-checker
  • add test coverage for the new list-based YAML shape

Why

The check job was failing on both #267 and #279 because upstream open-telemetry/opentelemetry-java-instrumentation changed docs/instrumentation-list.yaml from a map shape to a list shape. otel-checker still assumed the old format and TestFindSupportedLibrary started failing.

Verification

  • go test ./checks/sdk/java
  • mise run check

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@zeitlinger zeitlinger requested a review from a team as a code owner April 21, 2026 10:44
@zeitlinger zeitlinger merged commit aa8e375 into main Apr 21, 2026
11 checks passed
@zeitlinger zeitlinger deleted the fix/java-supported-libraries branch April 21, 2026 10:48
@zeitlinger
Copy link
Copy Markdown
Member Author

@jaydeluca here we still depend on the java format - not sure if that's still a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants