Add tests for pkg/util/test.AssertGatherAndCompare
#9543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
force-pushed
the
arve/add-gather-tests
branch
from
cf10a30
to
098f1b6
Compare
krajorama
approved these changes
Oct 7, 2024
Signed-off-by: Arve Knudsen <[email protected]>
aknuds1
force-pushed
the
arve/add-gather-tests
branch
from
098f1b6
to
1747a64
Compare
aknuds1
added
enhancement
krajorama
added a commit
that referenced
this pull request
Oct 15, 2024
This reverts commit e78254e.
4 tasks
krajorama
added a commit
that referenced
this pull request
Oct 16, 2024
* Test client_golang 1.20.5 Signed-off-by: György Krajcsovits <[email protected]> * Revert "Add tests for pkg/util/test.AssertGatherAndCompare (#9543)" This reverts commit e78254e. * Revert "Update module github.com/prometheus/client_golang to v1.20.4 (main) (#9307)" This reverts commit cd1294b. # Conflicts: # go.sum # vendor/github.com/prometheus/client_golang/prometheus/testutil/testutil.go # vendor/modules.txt * Clear go.mod replace Signed-off-by: György Krajcsovits <[email protected]> * Update mimir-prometheus at 5e9a771537ba To get grafana/mimir-prometheus#718 client_golang update to 1.20.5 to revert breaking changes to test utils. Signed-off-by: György Krajcsovits <[email protected]> * Apply suggestions from code review Co-authored-by: Arve Knudsen <[email protected]> * Apply suggestions Signed-off-by: György Krajcsovits <[email protected]> --------- Signed-off-by: György Krajcsovits <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Arve Knudsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Add tests for
pkg/util/test.AssertGatherAndCompare. Also fix said function for when nometricsare provided.Which issue(s) this PR fixes or relates to
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.