Removed unused utilities to add/remove source IP in the gRPC metadata #7530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitarvdimitrov
approved these changes
Mar 11, 2024
Contributor
dimitarvdimitrov
left a comment
dimitarvdimitrov
left a comment
There was a problem hiding this comment.
LGTM, I also couldn't find any references to GetSourceIPsFromOutgoingCtx in GH code search within grafana repos https://github.com/search?type=code&q=GetSourceIPsFromOutgoingCtx
4 tasks
Signed-off-by: Marco Pracucci <[email protected]>
pracucci
force-pushed
the
remove-x-forwarded-for-context-propagation
branch
from
fcaeee2 to
9db9c90
Compare
Collaborator
Author
|
I double checked it both in Mimir and GEM and I can't find any usage of these functions. I proceed merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
While working on #7529, I've noticed that we have utilities to add "source IP" in the gRPC metadata but we never read it (I've also checked GEM). This was introduced almost 4 years ago in Cortex (see PR): at that time we were also reading it in Cortex. I've the feeling this code is actually dead code no more used, so we can remove it (proposed in this PR), but please block me if you're aware such metadata is actually somewhere.
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.