Import jsonnet README.md #636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
pstibrany
approved these changes
Dec 21, 2021
Contributor
pstibrany
left a comment
pstibrany
left a comment
There was a problem hiding this comment.
Looks good, nice test of the script.
simonswine
approved these changes
Dec 21, 2021
Contributor
simonswine
left a comment
simonswine
left a comment
There was a problem hiding this comment.
Thank you for bringing this over. LGTM
A couple of thoughts I had about updates that would make sense at this point. None of them are hard requirements for merge.
Signed-off-by: Marco Pracucci <[email protected]>
Collaborator
Author
|
Thanks @pstibrany and @simonswine for your feedback! I've addressed your comments. |
simonswine
approved these changes
Dec 21, 2021
Contributor
simonswine
left a comment
simonswine
left a comment
There was a problem hiding this comment.
LGTM. Thanks for addressing the comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In the PR #506 we've imported the cortex-jsonnet. In this PR I'm importing its README + CI linter (used to test the command in the README). To improve the testing, I've moved the getting started to a bash script so that we can test its whole execution.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]