-
Couldn't load subscription status.
- Fork 656
Import cortex mixin from upstream #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…er-disk-utilisation Fixed ingester "Disk Space Utilization" to include any ingester.* PV
Signed-off-by: Goutham Veeramachaneni <[email protected]>
…icker Alert quicker for broken runtime config
Signed-off-by: Marco Pracucci <[email protected]>
…er-alerts Fixed ingester alerts to include any ingester.* job
…na/cortex-jsonnet#251) * Disable multi-selection for variables in resources dashboards. * CHANGELOG.md
Signed-off-by: Marco Pracucci <[email protected]>
…nshipper-blocks Added alert CortexIngesterHasUnshippedBlocks
Signed-off-by: Marco Pracucci <[email protected]>
…ster-memory-alert-threshold Increased CortexAllocatingTooMuchMemory alert threshold
Signed-off-by: Goutham Veeramachaneni <[email protected]>
…-memory-alert Add alert for etcd memory limits close
Signed-off-by: Mauro Stettler <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
…tooltip-decrescent-sorting Sort legend descending in the CPU/memory panels.
…h-alert Fixed CortexQuerierHighRefetchRate alert
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
…ueries-dashboard Add slow queries dashboard
- Update dashboard so it only shows under provisioned services and why - Add sizing rules based on limits. - Add some docs to the dashboard. Signed-off-by: Tom Wilkie <[email protected]>
Add recording rules to calculate Cortex scaling
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
…isk-panels Fixed "Disk Writes" and "Disk Reads" panels
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
…ecording-rules Pre-compute aggregations to optimize scaling recording rules
…ations-rules Add recording rules for Alertmanager dashboard,
This is a workaround for large clusters where this group can become slow to evaluate.
…rules Split `cortex_api` recording rule group into three groups.
Signed-off-by: Marco Pracucci <[email protected]>
…til-playbook Update gsutil installation playbook
This fixes panels where `cortex-gw` was hardcoded.
…ntainer-names Use `$._config.job_names.gateway` in resources dashboards.
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
…rtexIngesterReachingSeriesLimit Fine tune CortexIngesterReachingSeriesLimit alert
…tuck-rollout Add CortexRolloutStuck alert
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
…onsul-failures Added CortexFailingToTalkToConsul alert
|
I like the idea of having jsonnet stuff directly in mimir repository. Let's see what others think. |
|
The main issue I could see at present is that we can't use it for the customer-facing GEM jsonnet (at present) and it might create issues with private repositories in deployment_tools: A quick test locally was successful, though: |
|
If we do this, I would suggest to avoid importing history, because references in commit descriptions refer to PRs in different repository, and GitHub is all confused about them. |
|
I like having the mixin in the same repo. I notice this doesn't import the jsonnet for running Mimir with Tanka, should it? Another thing to note is that it would be nice to standardize where mixins are in a repository between Mimir, Loki, and Tempo. |
On the other side having history is quite handy. Maybe we can rewrite history commits comments to add a whitespace between |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to block this PR, but I will note that, for this to be useful in an OSS project it needs some guidance as to what the 3rd-party user should do with it. E.g. something in the Makefile, or documentation, maybe just a README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should say Mimir. Bit complicated to go through all the cases, since often the metric name has "cortex" in it.
8efac87 to
859efc9
Compare
I have replaced them with the full URL to the PR, but while doing that I made GitHub close the PR (pushing an intermediate state without common history). I will move this into a new PR and adress @bboreham's comments |
|
The new live PR is in #373 (sorry about that). I will address all comments from the other PR |
What this PR does:
Imports cortex mixin from upstream including history and placing it under jsonnet/mimir-mixin
Which issue(s) this PR fixes:
This allows to diverge with alerts and runbooks from the Cortex project.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]