Fix GossipMembersMismatch misfiring with remote ruler eval #2159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The alert doesn't take into account the queries that now have ruler- prepended to their name. This PR fixes it Signed-off-by: Dimitar Dimitrov <[email protected]>
pstibrany
reviewed
Jun 21, 2022
pracucci
approved these changes
Jun 21, 2022
pstibrany
approved these changes
Jun 21, 2022
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Jul 11, 2022
) * Fix GossipMembersMismatch misfiring with remote ruler eval The alert doesn't take into account the queries that now have ruler- prepended to their name. This PR fixes it Signed-off-by: Dimitar Dimitrov <[email protected]> * Simpler regexes * Update computed mixin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
The alert doesn't take into account the queries that now have ruler-
prepended to their name. This PR fixes it
Signed-off-by: Dimitar Dimitrov [email protected]
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]