Ruler: Report wider range of errors from remote rule evaluation queries. #2143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `cortex_ruler_queries_failed_total` metric should increment whenever a rule evaluation query fails. Before this change, errors would be ignored unless they are specifically of type`httpgrpc`. This means that many errors get lost, for example, connectivity errors coming from gRPC.
ortuman
approved these changes
Jun 20, 2022
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Jul 11, 2022
…es. (grafana#2143) The `cortex_ruler_queries_failed_total` metric should increment whenever a rule evaluation query fails. Before this change, errors would be ignored unless they are specifically of type`httpgrpc`. This means that many errors get lost, for example, connectivity errors coming from gRPC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
The
cortex_ruler_queries_failed_totalmetric should increment whenever a rule evaluation query fails, for a reason not caused by user behavior. Before this change, errors would be ignored unless they are specifically of typehttpgrpc. This means that many errors get lost, for example, connectivity errors coming from gRPC.Note: I inverted the logic a little so it reads "count everything except... " which I thought was easier to read.
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]