Add flag to make query-scheduler dashboard widgets optional. #1773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Carp <[email protected]>
jmcarp
force-pushed
the
dashboards-query-scheduler-optional
branch
from
db16021 to
ee14a11
Compare
Collaborator
|
I'm slightly more dubious about this. I think any production cluster should run with query-scheduler and we should advocate for that. I would rather fix the Helm chart. |
Contributor
Author
|
Sounds good, I'll close this. If this isn't already the case, maybe the docs should mark this component as recommended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Same as #1761, but for the query-scheduler, which is marked optional and currently not included in the helm chart.
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]