Skip to content

parquet converter: include user id in converter counter metrics #11966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025
Merged

parquet converter: include user id in converter counter metrics #11966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions pkg/parquetconverter/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,32 +10,32 @@ import (
)

type parquetConverterMetrics struct {
blocksConverted prometheus.Counter
blocksConvertedFailed prometheus.Counter
conversionDuration prometheus.Histogram
blocksConverted *prometheus.CounterVec
blocksConvertedFailed *prometheus.CounterVec
conversionDuration *prometheus.HistogramVec
tenantsDiscovered prometheus.Gauge
}

func newParquetConverterMetrics(reg prometheus.Registerer) parquetConverterMetrics {
var m parquetConverterMetrics

m.blocksConverted = promauto.With(reg).NewCounter(prometheus.CounterOpts{
m.blocksConverted = promauto.With(reg).NewCounterVec(prometheus.CounterOpts{
Name: "cortex_parquet_converter_blocks_converted_total",
Help: "Total number of blocks converted to parquet format",
})
}, []string{"user"})

m.blocksConvertedFailed = promauto.With(reg).NewCounter(prometheus.CounterOpts{
m.blocksConvertedFailed = promauto.With(reg).NewCounterVec(prometheus.CounterOpts{
Name: "cortex_parquet_converter_blocks_converted_failed_total",
Help: "Total number of blocks that failed to convert to parquet format",
})
}, []string{"user"})

m.conversionDuration = promauto.With(reg).NewHistogram(prometheus.HistogramOpts{
m.conversionDuration = promauto.With(reg).NewHistogramVec(prometheus.HistogramOpts{
Name: "cortex_parquet_converter_conversion_duration_seconds",
Help: "Time taken to convert a block to parquet format",
NativeHistogramBucketFactor: 1.1,
NativeHistogramMaxBucketNumber: 100,
NativeHistogramMinResetDuration: 1 * time.Hour,
})
}, []string{"user"})

m.tenantsDiscovered = promauto.With(reg).NewGauge(prometheus.GaugeOpts{
Name: "cortex_parquet_converter_tenants_discovered",
Expand Down
6 changes: 3 additions & 3 deletions pkg/parquetconverter/parquet_converter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,11 +304,11 @@ func (c *ParquetConverter) processBlock(ctx context.Context, userID string, meta
var skipped bool
defer func() {
duration := time.Since(start)
c.metrics.conversionDuration.Observe(duration.Seconds())
c.metrics.conversionDuration.WithLabelValues(userID).Observe(duration.Seconds())
if err != nil {
c.metrics.blocksConvertedFailed.Inc()
c.metrics.blocksConvertedFailed.WithLabelValues(userID).Inc()
} else if !skipped {
c.metrics.blocksConverted.Inc()
c.metrics.blocksConverted.WithLabelValues(userID).Inc()
}
}()

Expand Down
Loading