Skip to content

fix(parquet store gateway): close things that should be closed #11865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025
Merged

fix(parquet store gateway): close things that should be closed #11865

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0f5e1b
fix(parquet store gateway): closing things that should be closed
npazosmendez Jun 25, 2025
4dc8263
close only on success
npazosmendez Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/storage/parquet/block/lazy_reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import (
"github.com/go-kit/log"
"github.com/go-kit/log/level"
"github.com/grafana/dskit/gate"
"github.com/grafana/dskit/runutil"
"github.com/oklog/ulid/v2"
"github.com/parquet-go/parquet-go"
"github.com/pkg/errors"
Expand Down Expand Up @@ -210,7 +211,9 @@ func (r *LazyReaderLocalLabelsBucketChunks) convertLabelsFileToLocalDisk() error
if err != nil {
return errors.Wrap(err, "open bucket parquet labels file")
}
defer runutil.CloseWithLogOnErr(r.logger, bucketLabelsFile, "close bucket labels file")
bucketLabelsFileReader := parquet.NewGenericReader[any](bucketLabelsFile)
defer runutil.CloseWithLogOnErr(r.logger, bucketLabelsFileReader, "close bucket labels file reader")
labelsFileSchema, err := schema.FromLabelsFile(bucketLabelsFile.File)
if err != nil {
return errors.Wrap(err, "get schema from bucket parquet labels file")
Expand Down