This repository was archived by the owner on Aug 23, 2023. It is now read-only.
Getdata use pointslicepool and getdata return to pool #1924
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR on top of #1921 - review that first please
I will rebase this soon to make it less confusing.
This PR does two main things:
I have not yet been able to demonstrate memory savings.
Note that snapshots functionality is not working right now, but i have 2 screenshots of read nodes subjected to the same workload. memory is equivalent, but on the "after", allocation rate is significantly reduced. also notice more slices going into the pool, and all gets out of the pool succeeding.
PRE
POST