Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

cleanup dataprocessor code #1753

Merged
merged 2 commits into from
Apr 7, 2020
Merged

cleanup dataprocessor code #1753

merged 2 commits into from
Apr 7, 2020

Conversation

Dieterbe
Copy link
Contributor

@Dieterbe Dieterbe commented Apr 6, 2020

No description provided.

@Dieterbe Dieterbe requested a review from replay April 6, 2020 20:27
@replay
Copy link
Contributor

replay commented Apr 6, 2020

I guess the string DP is for DataProcessing? I don't think that's obvious, and f.e. the stuff in /input could also be considered "data processing". I think it would be nice to have some standard defining what our log prefix should be, but anyway for now this PR is still an improvement to master

@replay
Copy link
Contributor

replay commented Apr 6, 2020

Side note: I've noticed that in Cortex they're using a logger which automatically adds a field to every log statement which indicates where this log line has been produced. I think that's a really nice solution. Logrus could do that too with log.SetReportCaller(true), this would make our log statement prefixes redundant and we could remove them

Co-Authored-By: Sean Hanson <[email protected]>
@Dieterbe Dieterbe merged commit e5cbe20 into master Apr 7, 2020
@Dieterbe Dieterbe deleted the cleanup-dataprocessor branch April 7, 2020 07:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants