Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

update cass/bt index when deleting tagged metrics #1657

Merged
merged 2 commits into from
Jan 31, 2020
Merged

update cass/bt index when deleting tagged metrics #1657

merged 2 commits into from
Jan 31, 2020

Conversation

replay
Copy link
Contributor

@replay replay commented Jan 31, 2020

This implements deletion of tagged metrics in the cass / bt indexes, which is currently missing.

Fixes: #1640

@replay replay requested review from fitzoh and a team January 31, 2020 16:51
fitzoh
fitzoh approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@fitzoh fitzoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One minor comment, feel free to disregard.

At some point it might make sense to refactor the interfaces to unify Delete and DeleteTagged, but that's out of scope for this PR.

@replay replay merged commit eeb36a4 into master Jan 31, 2020
@replay replay deleted the persist_delete_of_tagged_metrics branch January 31, 2020 20:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fitzoh fitzoh fitzoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deleting metrics via the /tags/delSeries endpoint also needs to delete from persistent index
2 participants
@replay @fitzoh