-
Notifications
You must be signed in to change notification settings - Fork 107
Enable metrics publishing for mt-gateway #1645
Conversation
cmd/mt-gateway/main.go
Outdated
|
||
// stats | ||
statsEnabled = flag.Bool("stats-enabled", false, "enable sending graphite messages for instrumentation") | ||
statsPrefix = flag.String("stats-prefix", "tsdb-gw.stats.default.$hostname", "stats prefix (will add trailing dot automatically if needed)") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the default value here does not match the one in the config file. I think it should also be mt-gateway.stats.default.$hostname
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, e5ee174
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one very minor issue to fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before we merge. can you confirm that you can take a tsdb-gw dashboard, |
can we ? |
Copied over in c803c82... Not sure if we want to leave them as is or switch to tag based metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is this copied over? the code looks quite different, making it hard to compare.. can you just make a literal copy, and maybe make any needed changes in a separate commit?
also, that screenie looks good. can you confirm these stats similarly?
c803c82
to
3615112
Compare
Initial import in 1b16b0d, changes in subsequent commits |
After some tweaks to get things up and running... The response codes were worrying me a little bit, but I was able to confirm that there's data there through the explore view. (The query the dashboard was running was |
As requested here.
Note that there are a couple places where prometheus instrumentation is used that have not been addressed:
metrictank/cmd/mt-gateway/ingest/metrics.go
Line 29 in d37ddf3
metrictank/publish/publish.go
Line 13 in d37ddf3