Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

Remove promql #1613

Merged
merged 6 commits into from
Jan 22, 2020
Merged

Remove promql #1613

merged 6 commits into from
Jan 22, 2020

Conversation

Dieterbe
Copy link
Contributor

fix #1454

@fitzoh
Copy link
Contributor

fitzoh commented Jan 17, 2020

Should input/prometheus go away as well?

@Dieterbe
Copy link
Contributor Author

Dieterbe commented Jan 17, 2020

yes. actually we should probably grep around a bit more too. there might be some documentation talking about prometheus too, that we should clean up. and config files that may have settings about the prometheus input or query endpoint
do you mind continuing this ?
if you remove code, be sure to run ./scripts/qa/vendor.sh and if needed dep ensure to clean up dependencies.

@fitzoh fitzoh requested a review from a team January 21, 2020 07:52
@fitzoh
Copy link
Contributor

fitzoh commented Jan 21, 2020

Think this is good to go aside from a changelog update

@Dieterbe
Copy link
Contributor Author

looks great @fitzoh . unfortunately i can't approve this PR because it's my own :)

@Dieterbe Dieterbe merged commit d77c5a3 into master Jan 22, 2020
@Dieterbe Dieterbe deleted the remove-promql branch January 22, 2020 08:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove promql support
2 participants