This repository was archived by the owner on Aug 23, 2023. It is now read-only.
add filter to only load latest metricDef from bt idx #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodsaj
approved these changes
Dec 6, 2019
replay
deleted the
ensure_latest_version_of_metricDef_gets_loaded_from_bt_idx
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this ensures that when we load metric definitions from the big table index we only load each cell's latest version, as opposed to loading any version that has been stored since the last bt compaction, using the
LatestNFilter()(https://godoc.org/cloud.google.com/go/bigtable#LatestNFilter)Fixes: #1563