Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

Added option 'reorderBufferAllowUpdate' to storage schemas #1552

Merged
merged 1 commit into from
Nov 27, 2019

Conversation

fkaleo
Copy link
Contributor

@fkaleo fkaleo commented Nov 26, 2019

Added option 'reorderBufferAllowUpdate' to storage schemas.
When enabled, a point sent within the reorder buffer window that has a timestamp already used by a point in the reorder buffer will overwrite the existing value.

Fix #1531

@fkaleo fkaleo force-pushed the rob_overwrite_option branch from 7c7964a to fbda8de Compare November 26, 2019 13:44
@fkaleo fkaleo changed the title [WIP] Added option "overwrite-duplicate" Added option "overwrite-duplicate" Nov 26, 2019
@fkaleo fkaleo requested a review from Dieterbe November 26, 2019 14:05
@fkaleo fkaleo marked this pull request as ready for review November 26, 2019 14:05
@fkaleo fkaleo changed the title Added option "overwrite-duplicate" Added option "overwrite-duplicate" for reorder buffer Nov 26, 2019
@Dieterbe
Copy link
Contributor

the reorderbuffer setting is per metrics pattern inside of storage-schemas.conf
the assumption is that different kinds of data may have different needs (some may not need ROB, others may need it, some may require a bigger buffer than others)
I think it would make sense to implement this setting the same way: users may only want to allow overwriting for certain metrics but not others.

also can we simplify the name of the setting? e.g. allow-update

@fkaleo fkaleo force-pushed the rob_overwrite_option branch 2 times, most recently from d2ee369 to 8287d4a Compare November 26, 2019 15:20
@fkaleo
Copy link
Contributor Author

fkaleo commented Nov 26, 2019

the reorderbuffer setting is per metrics pattern inside of storage-schemas.conf
the assumption is that different kinds of data may have different needs (some may not need ROB, others may need it, some may require a bigger buffer than others)
I think it would make sense to implement this setting the same way: users may only want to allow overwriting for certain metrics but not others.

also can we simplify the name of the setting? e.g. allow-update

Thanks, I reworked the whole thing to address all your good remarks.

@fkaleo fkaleo changed the title Added option "overwrite-duplicate" for reorder buffer Added option 'reorderBufferAllowUpdate' to storage schemas Nov 26, 2019
Copy link
Contributor

@Dieterbe Dieterbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor tweaks needed, LGTM

@Dieterbe Dieterbe force-pushed the rob_overwrite_option branch from e4f2a7d to f4299fd Compare November 27, 2019 08:49
@Dieterbe Dieterbe merged commit 6cd12d6 into master Nov 27, 2019
@Dieterbe Dieterbe deleted the rob_overwrite_option branch November 27, 2019 08:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

re-allow point updating with reorder buffer
2 participants