Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

Add absolute function #1300

Merged
merged 3 commits into from
May 6, 2019
Merged

Add absolute function #1300

merged 3 commits into from
May 6, 2019

Conversation

the-real-stiven
Copy link
Contributor

Native implementation of absolute() Graphite function. (http://graphite.readthedocs.io/en/latest/functions.html#graphite.render.functions.absolute)

Speed improvement:

---------- Native targets/absolute.json Latencies ----------
Mean: 6.219059ms
50th percentile: 5.131637ms
95th percentile: 12.810392ms
99th percentile: 19.082978ms
Max: 28.004244ms
Success: 100%
Errors: []

---------- Graphite (Python) targets/absolute.json Latencies ----------
Mean: 21.843168ms
50th percentile: 20.08863ms
95th percentile: 30.953993ms
99th percentile: 46.838977ms
Max: 249.920044ms

Success: 100%
Errors: []

---------- Speed Improvement ----------
Mean: x3.5
50th percentile: x3.9
95th percentile: x2.4
99th percentile: x2.5
Max: x8.9

@the-real-stiven
Copy link
Contributor Author

@Dieterbe

Copy link
Contributor

@Dieterbe Dieterbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
if you use any tools to aid with building these functions, please share them. e.g. can you put them in a gist or in a git repo somewhere?

@Dieterbe Dieterbe merged commit 7d9a362 into grafana:master May 6, 2019
@the-real-stiven the-real-stiven deleted the absolute branch May 13, 2019 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants